| commit | d3dd429cdad9cc8d4fd049a3c3cef63a3ed2526f | |
| author | Jan Oravec <jan@fb.com> | |
| Tue, 9 Mar 2021 00:22:14 +0000 (8 16:22 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 9 Mar 2021 00:24:15 +0000 (8 16:24 -0800) | ||
| tree | 16d6957b212cb2f3534c1cb76fbae18b998cb48e | treesnapshot (tar.gz zip) |
| parent | 6388f29e731e619efc12d51aaa809872b202886a | commitdiff |
Make stack_below() not go above
Summary:
In an attempt to redefine expectations, stack_below() went above and included
one more cell.
Fix it and update all its call sites to compensate, which cancelled out the off
by one arithmetics at all call sites. Except of ContEnter, which did it wrong
(benign), so fix it.
Reviewed By: oulgen
Differential Revision: D26886840
fbshipit-source-id: 0eefdf4b27acefde092ff1a609e30c016575264d
Summary:
In an attempt to redefine expectations, stack_below() went above and included
one more cell.
Fix it and update all its call sites to compensate, which cancelled out the off
by one arithmetics at all call sites. Except of ContEnter, which did it wrong
(benign), so fix it.
Reviewed By: oulgen
Differential Revision: D26886840
fbshipit-source-id: 0eefdf4b27acefde092ff1a609e30c016575264d
| hphp/runtime/vm/jit/memory-effects.cpp | diffblobblamehistory |