| commit | d35ff4cc856be411b8ca22131221b114323d6371 | |
| author | Max Sherman <jonaldislarry@fb.com> | |
| Mon, 15 Aug 2016 18:50:07 +0000 (15 11:50 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Mon, 15 Aug 2016 20:50:24 +0000 (15 13:50 -0700) | ||
| tree | 39854e147bfeb5478ac92c39d4d0374507f829c1 | treesnapshot (tar.gz zip) |
| parent | e45f4bed2f848fc05fa1c605833769fa6bd5968f | commitdiff |
Set bypass access check in XDebug debugger
Summary:
Nuclide's debugger sets this show_hidden feature, which according to the XDebug spec can be
> set by the IDE if it wants to have more detailed internal information on properties (eg. private members of classes, etc.)
Despite this, our debugger will throw an exception on private property accesses, which is pretty goofy. Setting this xdebug feature should let the debugger bypass these checks.
Reviewed By: yinghuitan
Differential Revision: D3704307
fbshipit-source-id: d3d597883b4d9a6e6dc537101741a53f3b30f122
Summary:
Nuclide's debugger sets this show_hidden feature, which according to the XDebug spec can be
> set by the IDE if it wants to have more detailed internal information on properties (eg. private members of classes, etc.)
Despite this, our debugger will throw an exception on private property accesses, which is pretty goofy. Setting this xdebug feature should let the debugger bypass these checks.
Reviewed By: yinghuitan
Differential Revision: D3704307
fbshipit-source-id: d3d597883b4d9a6e6dc537101741a53f3b30f122
| hphp/runtime/ext/xdebug/xdebug_command.cpp | diffblobblamehistory |