| commit | d244a247cc3a46dcce3b7a1aaeaf8e9e8375f547 | |
| author | Eric Lippert <ericlippert@fb.com> | |
| Fri, 8 Apr 2016 15:26:30 +0000 (8 08:26 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Fri, 8 Apr 2016 15:30:32 +0000 (8 08:30 -0700) | ||
| tree | 3753def5850f2fb1dfd4192548c67cb14202d92e | treesnapshot (tar.gz zip) |
| parent | ffa0faaccc4aa198c197b7061a13f394fddab3cd | commitdiff |
Eliminate unnecessary local
Summary:I thought my first commit to the real codebase should be pretty obviously correct!
While trying to understand the callback code in the local variable analyzer I noticed that
local name p is always assigned the value of formal parameter p; this is basically
"let p = p in... " which seems pointless. I've removed the local, which then meant that local
y could also be safely removed.
Reviewed By: dlreeves
Differential Revision: D3154444
fb-gh-sync-id: ff53b50dd28beed0885d47ac9d6b80645873c977
fbshipit-source-id: ff53b50dd28beed0885d47ac9d6b80645873c977
Summary:I thought my first commit to the real codebase should be pretty obviously correct!
While trying to understand the callback code in the local variable analyzer I noticed that
local name p is always assigned the value of formal parameter p; this is basically
"let p = p in... " which seems pointless. I've removed the local, which then meant that local
y could also be safely removed.
Reviewed By: dlreeves
Differential Revision: D3154444
fb-gh-sync-id: ff53b50dd28beed0885d47ac9d6b80645873c977
fbshipit-source-id: ff53b50dd28beed0885d47ac9d6b80645873c977
| hphp/hack/src/naming/naming.ml | diffblobblamehistory |