| commit | d22f91b7bcb931414546668e702794211822f0a3 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Wed, 31 Aug 2022 15:45:22 +0000 (31 08:45 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 31 Aug 2022 15:45:22 +0000 (31 08:45 -0700) | ||
| tree | 2e58edc6930fb0a985390ee7a931351af7a47fb8 | treesnapshot (tar.gz zip) |
| parent | 4cb3003e42925fde2a89cb09ddb8f8934d39a605 | commitdiff |
names/datatypes.rs shouldn't re-export ToplevelCanonSymbolHash
Summary:
I just don't like it when a crate re-exports a type from a different crate. It introduces confusion -- where does the type properly belong? In this case, is ToplevelCanonSymbolHash a naming_sqlite.rs wrapper type for sql, or is it the same as hh24_types::ToplevelCanonSymbolHash?
So I'm removing the "pub use"
Reviewed By: bobrenjc93
Differential Revision: D39137831
fbshipit-source-id: 944b8ac09a4e1ef5d18b150309a182e767772989
Summary:
I just don't like it when a crate re-exports a type from a different crate. It introduces confusion -- where does the type properly belong? In this case, is ToplevelCanonSymbolHash a naming_sqlite.rs wrapper type for sql, or is it the same as hh24_types::ToplevelCanonSymbolHash?
So I'm removing the "pub use"
Reviewed By: bobrenjc93
Differential Revision: D39137831
fbshipit-source-id: 944b8ac09a4e1ef5d18b150309a182e767772989