| commit | d1f2cbcb1c342a7d45375f253789e3099b6fb0c0 | |
| author | Andrew Kennedy <akenn@fb.com> | |
| Wed, 16 Jan 2019 17:28:06 +0000 (16 09:28 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 16 Jan 2019 17:31:43 +0000 (16 09:31 -0800) | ||
| tree | 78df5a6dc7b350cc320a93a2af236c5ec5290424 | treesnapshot (tar.gz zip) |
| parent | 796aad97181a37638a3eb26355a2f74118962226 | commitdiff |
Do not infer the any type when lambda has no return type annotation
Summary:
In some circumstances the type displayed by `hh_show` for a lambda involved the "any" type, displayed as `_`.
This is an unsoundness in the checking of lambdas (see tests).
Fix is simply to pass `None` for the expected type in bidirectional type checking, when there is no explicit return hint.
Reviewed By: arun11111
Differential Revision: D13692386
fbshipit-source-id: df34a257d256e2329637247a6a111af493bcd2d0
Summary:
In some circumstances the type displayed by `hh_show` for a lambda involved the "any" type, displayed as `_`.
This is an unsoundness in the checking of lambdas (see tests).
Fix is simply to pass `None` for the expected type in bidirectional type checking, when there is no explicit return hint.
Reviewed By: arun11111
Differential Revision: D13692386
fbshipit-source-id: df34a257d256e2329637247a6a111af493bcd2d0
| hphp/hack/src/typing/typing.ml | diffblobblamehistory | |
| hphp/hack/src/typing/typing_log.ml | diffblobblamehistory | |
| hphp/hack/test/infer_return_types/array.php.exp | diffblobblamehistory | |
| hphp/hack/test/typecheck/lambda/lambda_any_bad.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/lambda/lambda_any_bad.php.exp | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/lambda/lambda_any_return_bug.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/lambda/lambda_any_return_bug.php.exp | [new file with mode: 0644] | blob |