| commit | d1979de61993b0224c6751e51fab7ceed68400a1 | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Tue, 21 Jul 2020 01:36:04 +0000 (20 18:36 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 21 Jul 2020 01:38:50 +0000 (20 18:38 -0700) | ||
| tree | a663f0182b79d66ed5a37a30b408decf7cd75243 | treesnapshot (tar.gz zip) |
| parent | 68247dd574555e71563556fd48d9ad69b1bafb6b | commitdiff |
Eliminate ArrayData::plusEq
Summary:
Another PHPism down. This operation wasn't HAM-safe, and it was a little nuts to boot.
There are two places that C++ code invoked this operator. In the debugger, we maintain the behavior by manual iteration. In ext_soap, we're listing available functions; there's a debugger command that does the same thing and assumes that system and user functions are disjoint, so maybe we can assume that too? Alternatively, I could just raise instead.
Reviewed By: billf, dneiter
Differential Revision: D22627817
fbshipit-source-id: 5a7a3ab3e097fcec8464301905e5d3c175999f48
Summary:
Another PHPism down. This operation wasn't HAM-safe, and it was a little nuts to boot.
There are two places that C++ code invoked this operator. In the debugger, we maintain the behavior by manual iteration. In ext_soap, we're listing available functions; there's a debugger command that does the same thing and assumes that system and user functions are disjoint, so maybe we can assume that too? Alternatively, I could just raise instead.
Reviewed By: billf, dneiter
Differential Revision: D22627817
fbshipit-source-id: 5a7a3ab3e097fcec8464301905e5d3c175999f48
173 files changed: