Make Aast_defs.Hfun a record
commitd0cd070540d289f09619a52236991ef9eef0a6b5
authorDwayne Reeves <dreeves@fb.com>
Thu, 19 Sep 2019 19:27:37 +0000 (19 12:27 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Thu, 19 Sep 2019 19:31:14 +0000 (19 12:31 -0700)
tree3c692e5b65c3e23f33686bdbeb9c9b2e347f47a9
parentc2713ba0d02e956894013a3844b1d8e3f96aa8bd
Make Aast_defs.Hfun a record

Summary:
This is a tuple with a bunch of fields which makes it harder to work with. Change it to a record.

I also added some TODOs to look into some cases that look like bugs potentially.

Differential Revision: D17450330

fbshipit-source-id: 022075f9a5baebcc3bec2bdb4ad220e30fffbfbf
14 files changed:
hphp/hack/src/annotated_ast/aast_defs.ml
hphp/hack/src/annotated_ast/ast_to_aast.ml
hphp/hack/src/decl/decl_hint.ml
hphp/hack/src/hhbc/emit_expression.ml
hphp/hack/src/hhbc/emit_type_constant.ml
hphp/hack/src/hhbc/emit_type_hint.ml
hphp/hack/src/naming/naming.ml
hphp/hack/src/typing/nastCheck.ml
hphp/hack/src/typing/tast_check/instantiability_check.ml
hphp/hack/src/typing/tast_check/type_params_arity_check.ml
hphp/hack/test/tast/array_map.php.exp
hphp/hack/test/tast/lambda_contextual.php.exp
hphp/hack/test/tast/reactive.php.exp
hphp/hack/test/tast/singleton_unresolved_function_call.php.exp