review feedback from D17727600nightly-2019.10.04
commitd0072d2a8b209260488efa2740a906f1cbb4f6aa
authorDaniel Neiter <dneiter@fb.com>
Fri, 4 Oct 2019 02:04:48 +0000 (3 19:04 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Fri, 4 Oct 2019 02:06:31 +0000 (3 19:06 -0700)
treef9c96d21a204e2812c858474182d150bd2bad6d7
parentbebd73657737fd0eb7ed70eafc5f2bd2a622cd3f
review feedback from D17727600

Summary: I've missed applying suggested changes to one of diffs in the stack. Sending a separate diff instead.

Reviewed By: billf

Differential Revision: D17746389

fbshipit-source-id: 9700bce0958690a32842670d53e87723a41730b3
hphp/test/slow/spec/tests/expressions/primary_expressions/intrinsics_unset.php
hphp/test/slow/spec/tests/expressions/primary_expressions/intrinsics_unset.php.expectf
hphp/test/slow/spec/tests/functions/passing_arguments.php
hphp/test/slow/spec/tests/functions/type_hints.php
hphp/test/slow/spec/tests/functions/type_hints.php.expect