migrate ext_icu_collator to use inout parameters instead of references
commitcfcce40ae9fc1cba97bc596e87e55de6763ebb79
authorDaniel Neiter <dneiter@fb.com>
Tue, 1 Oct 2019 05:20:33 +0000 (30 22:20 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 1 Oct 2019 05:22:24 +0000 (30 22:22 -0700)
tree0c75faf6f295a34953922e2bd9f9c25dbecd7288
parent1236df8de91b9d867e7acb4544e1cf48ae4d5e60
migrate ext_icu_collator to use inout parameters instead of references

Summary:
1. Convert ext_icu_collator to use inout parameters instead of references.
2. Remove optional reference parameters from IntlDateFormatter::parse() and NumberFormatter::parse() - both functions have parseWithPosition() alternatives, which take inout parameters.

Reviewed By: billf

Differential Revision: D17672557

fbshipit-source-id: 7f93ce6222707cddcafd11b9e11c6e53597cedbe
19 files changed:
hphp/hack/hhi/NumberFormatter.hhi
hphp/hack/hhi/stdlib/builtins_intl.hhi
hphp/runtime/ext/icu/ext_icu_collator.cpp
hphp/runtime/ext/icu/ext_icu_collator.php
hphp/runtime/ext/icu/ext_icu_date_fmt.php
hphp/runtime/ext/icu/ext_icu_num_fmt.php
hphp/test/slow/ext_collator/1810.php
hphp/test/zend/good/ext/intl/tests/bug60192-sort.php
hphp/test/zend/good/ext/intl/tests/bug60192-sortwithsortkeys.php
hphp/test/zend/good/ext/intl/tests/collation_customization.php
hphp/test/zend/good/ext/intl/tests/collator_asort_variant2.php
hphp/test/zend/good/ext/intl/tests/collator_sort_variant2.php
hphp/test/zend/good/ext/intl/tests/collator_sort_with_sort_keys_variant2.php
hphp/test/zend/good/ext/intl/tests/formatter_parse_currency.php
hphp/test/zend/good/ext/intl/tests/regression_sort_and_cow.php
hphp/test/zend/good/ext/intl/tests/regression_sort_eq.php
hphp/test/zend/good/ext/intl/tests/regression_sortwsk_and_cow.php
hphp/test/zend/good/ext/intl/tests/regression_sortwsk_eq.php
hphp/test/zend/good/ext/intl/tests/ut_common.inc