Clean up tracing ring buffer, add gdb command to inspect it
commitcf164b1043594718e8dcbd72534a42fc135bc59b
authorBrett Simmers <bsimmers@fb.com>
Fri, 12 Jan 2018 16:39:31 +0000 (12 08:39 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 12 Jan 2018 16:52:31 +0000 (12 08:52 -0800)
tree55dad7a8cd3b5fcecf42e4782f11c48707c437df
parentf80d042537490641ca5d868706c802c42e75f7c7
Clean up tracing ring buffer, add gdb command to inspect it

Summary:
- Restructure RingBufferEntry a little to clarify which fields are used
  by which entry types.
- Add a Generic entry type that's similar to Msg, but only
  supports zero-terminated, static strings, and has a full 64-bit data field.
- Add the rbprint gdb command, which is a loose copy of dumpRingBuffer().
- Add a gdb pretty-printer for SrcKey.

Reviewed By: mxw

Differential Revision: D6697081

fbshipit-source-id: 44eb4be38f796e8421f4d5fe18f3376a72451755
hphp/runtime/vm/ringbuffer-print.cpp
hphp/tools/gdb/hhvm.py
hphp/tools/gdb/pretty.py
hphp/tools/gdb/ringbuffer.py [new file with mode: 0644]
hphp/util/ringbuffer.cpp
hphp/util/ringbuffer.h