Store path in ExprPos
commitce79ffbf15e7f0d1d29344974e88871a36345cbc
authorWilfred Hughes <wilfred@fb.com>
Wed, 17 Feb 2021 19:10:19 +0000 (17 11:10 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 17 Feb 2021 19:12:50 +0000 (17 11:12 -0800)
treef6d3440457e05e59633e9fcbaed56861f9114683
parent1b01f650ce332b07c49b3c28565d61b8edd83f63
Store path in ExprPos

Summary:
Currently we pass `ExprPos` and the file path to `ExprTree::__construct`, but other methods (e.g. `MyVisitor::lambdaLiteral`) only get `ExprPos`.

Keep the API simple and consistent by storing the path in `ExprPos`. This is also consistent with the `Pos.t` type we use internally.

Differential Revision: D26032706

fbshipit-source-id: a53c4dc66fc90ea7deb2823ba4a9ebc0021412ad
77 files changed:
hphp/hack/src/parser/lowerer/desugar_expression_tree.rs
hphp/hack/test/hhi/expr_tree.hhi
hphp/hack/test/nast/expression_tree.php.exp
hphp/hack/test/nast/expression_tree_assign.php.exp
hphp/hack/test/nast/expression_tree_for.php.exp
hphp/hack/test/nast/expression_tree_invalid.php.exp
hphp/hack/test/nast/expression_tree_loop.php.exp
hphp/hack/test/nast/expression_tree_splice.php.exp
hphp/hack/test/typecheck/expression_trees/arithmetic.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/assign.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/async_function.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/boolean_and.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/boolean_check.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/boolean_operators.php.exp
hphp/hack/test/typecheck/expression_trees/boolean_operators.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/boolean_or.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/bound_variable_lambda.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/break.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/comparison_operators.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/consecutive_splicing.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/continue.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/elvis.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/float.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/fully_qualified.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/hover_type.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/if.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/instance_method_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/invalid_call1.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/invalid_call2.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/invalid_call3.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/invalid_operator.php.exp
hphp/hack/test/typecheck/expression_trees/invalid_operator.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/lambda_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/loop.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/mismatched_types.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/namespace.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/nested_expression_tree_lambda.php.exp
hphp/hack/test/typecheck/expression_trees/nested_expression_tree_lambda.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/nonvoid_return.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/not.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/null.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/parent_static_method_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/parse_constants.php.exp
hphp/hack/test/typecheck/expression_trees/parse_constants.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/potential_void_return.php.exp
hphp/hack/test/typecheck/expression_trees/potential_void_return.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/self_static_method_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_err1.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err2.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err2.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_err3.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err3.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_err4.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err4.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_infer.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_state.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_state2.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_state3.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_state4.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_variable2.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_variable3.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/splice_variable4.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/static_method_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/static_static_method_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/ternary.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/unbound_variables.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/variable_call.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/void_return.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/void_return_errors.php.exp
hphp/hack/test/typecheck/expression_trees/void_return_errors.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/void_return_errors2.php.exp
hphp/hack/test/typecheck/expression_trees/void_return_errors2.php.like_types.exp
hphp/hack/test/typecheck/expression_trees/void_return_errors3.php.like_types.exp
hphp/test/slow/expression_trees/basic.php