| commit | cd20b88de1e4f71913fce0eb0b642ddc46f6a177 | |
| author | Thomas Jiang <thomasjiang@fb.com> | |
| Fri, 27 Sep 2019 23:25:12 +0000 (27 16:25 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 27 Sep 2019 23:30:22 +0000 (27 16:30 -0700) | ||
| tree | c7d012e662aa279413917668df20600f56b2e20b | treesnapshot (tar.gz zip) |
| parent | dc76ae047a3ac4a0c3e92517b16ff5c2de040b4e | commitdiff |
Move tparam duplicate check to nast_check
Summary:
Trying to break up naming into separate components - This stack attempts to clean up and move error checks from naming.ml to into nast_check by converting them to nast_visitors. Some of these passes do not require names or calls to the naming table so they could be parser errors - but keeping them consistent until we decide what we want to do with them later.
Moves check of duplicates of generic names
Reviewed By: kmeht
Differential Revision: D17531449
fbshipit-source-id: ff4dcbe62887ecade78544f6e5e5e98c210fc948
Summary:
Trying to break up naming into separate components - This stack attempts to clean up and move error checks from naming.ml to into nast_check by converting them to nast_visitors. Some of these passes do not require names or calls to the naming table so they could be parser errors - but keeping them consistent until we decide what we want to do with them later.
Moves check of duplicates of generic names
Reviewed By: kmeht
Differential Revision: D17531449
fbshipit-source-id: ff4dcbe62887ecade78544f6e5e5e98c210fc948
| hphp/hack/src/naming/naming.ml | diffblobblamehistory | |
| hphp/hack/src/typing/nast_check/nast_generics_name_check.ml | diffblobblamehistory |