| commit | ccff0be23e8d2c6d3ae7304f5c8dd57905485dd3 | |
| author | David Snider <dizzy@fb.com> | |
| Wed, 17 Feb 2021 00:40:14 +0000 (16 16:40 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 17 Feb 2021 00:44:00 +0000 (16 16:44 -0800) | ||
| tree | d8cefa8dc544a93f476c4441b92fbdea5fa22423 | treesnapshot (tar.gz zip) |
| parent | de0d2bb1546ba72fc77f09f2b3c4a87e3ab8a943 | commitdiff |
String Concatenation/Interpolation
Summary:
Emit notices for usage of double, resource, bool, and null in string concatenation and interpolation.
I had to move convtvtostr and convrestostr into manual lowering due to an issue with threading a nullptr in extra data through the native-calls simplified version.
Of all the changed pieces, only tvConcatEq was remotely hot with .14% GCPU. To avoid potentially unnecessary complexity, I read the flag within that function rather tham doing it within the jit. Since the flag is only actually processed in the colder situations, I am hopeful there won't be anything resembling a regression.
Differential Revision: D26444161
fbshipit-source-id: df5e85638dd7018db0e7dbaa0b16aebca47bf1f4
Summary:
Emit notices for usage of double, resource, bool, and null in string concatenation and interpolation.
I had to move convtvtostr and convrestostr into manual lowering due to an issue with threading a nullptr in extra data through the native-calls simplified version.
Of all the changed pieces, only tvConcatEq was remotely hot with .14% GCPU. To avoid potentially unnecessary complexity, I read the flag within that function rather tham doing it within the jit. Since the flag is only actually processed in the colder situations, I am hopeful there won't be anything resembling a regression.
Differential Revision: D26444161
fbshipit-source-id: df5e85638dd7018db0e7dbaa0b16aebca47bf1f4
38 files changed: