| commit | ccf2ec3e25a6e59776ea66a245c569e41fe2f541 | |
| author | Oguz Ulgen <oulgen@fb.com> | |
| Wed, 4 Aug 2021 01:44:17 +0000 (3 18:44 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 4 Aug 2021 01:45:55 +0000 (3 18:45 -0700) | ||
| tree | 53ba0c2aeadd8bc4aaa64044bed91048704ff7f9 | treesnapshot (tar.gz zip) |
| parent | 5f5228dfb61d21df6cf38e196613c2255eeefa18 | commitdiff |
Compact the FCallArgs encoding
Summary:
By increase size of FCallArgs::Flags, we can compact the total size of FCallArgs encoding. Instead of unconditionally allocating 32 bits each time, we use the extra space at the end of `FCallArgs::Flags` to store the num args.
I have to increase the size of `FCallArgs::Flags` for readonly flags anyway, so this diff ends up being win-win.
Reviewed By: jano
Differential Revision: D30077395
fbshipit-source-id: 481625c3ac4aef06de96f781b50ae33ebfaf1936
Summary:
By increase size of FCallArgs::Flags, we can compact the total size of FCallArgs encoding. Instead of unconditionally allocating 32 bits each time, we use the extra space at the end of `FCallArgs::Flags` to store the num args.
I have to increase the size of `FCallArgs::Flags` for readonly flags anyway, so this diff ends up being win-win.
Reviewed By: jano
Differential Revision: D30077395
fbshipit-source-id: 481625c3ac4aef06de96f781b50ae33ebfaf1936
| hphp/runtime/vm/hhbc-codec.cpp | diffblobblamehistory | |
| hphp/runtime/vm/hhbc.h | diffblobblamehistory |