| commit | ccc1053ee282cf506a7319541985073819ebc751 | |
| author | Alex Malyshev <alexanderm@fb.com> | |
| Tue, 9 Jun 2015 09:07:59 +0000 (9 02:07 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Tue, 9 Jun 2015 09:32:22 +0000 (9 02:32 -0700) | ||
| tree | e07223afc6ec88528375220101326043e78e0f22 | treesnapshot (tar.gz zip) |
| parent | 1100e471847b144850917aea3fda0dba4b86d99b | commitdiff |
Fix hhbbc not emitting RATs for public static properties.
Summary: Noticed this after looking at some CGetS codegen. hhbbc would emit an
AssertRATStk after the CGetS, but the CGetS itself would be translated with a
PtrToSPropGen type every time. Turned out this was because the hhbbc emitter
was only emitting RATs for private properties.
Reviewed By: @jdelong
Differential Revision: D2107485
Summary: Noticed this after looking at some CGetS codegen. hhbbc would emit an
AssertRATStk after the CGetS, but the CGetS itself would be translated with a
PtrToSPropGen type every time. Turned out this was because the hhbbc emitter
was only emitting RATs for private properties.
Reviewed By: @jdelong
Differential Revision: D2107485
| hphp/hhbbc/emit.cpp | diffblobblamehistory | |
| hphp/hhbbc/index.cpp | diffblobblamehistory | |
| hphp/hhbbc/index.h | diffblobblamehistory |