remove operator-> from String
commitcb436ccc00c7f6010aa7311d893c9b3acc40374c
authorPaul Tarjan <ptarjan@fb.com>
Wed, 19 Feb 2014 19:29:22 +0000 (19 11:29 -0800)
committerSara Golemon <sgolemon@fb.com>
Mon, 10 Mar 2014 20:08:32 +0000 (10 13:08 -0700)
tree40962054ed9d1e160ed7012dee0301c99389383e
parent9a0d9974ed8d02fd35643fb79536e6902244cb31
remove operator-> from String

Basically i removed the operator, then opened all the files with compilation errors and either used a method if it already existed or used `.get()` if i thought it was seldomly used.

We can do another pass after and replace all the `.get()->foo()` with `.foo()` if `foo()` is really popular. (`isame` seems plausible).

Reviewed By: @edwinsmith

Differential Revision: D1180662
46 files changed:
hphp/compiler/analysis/emitter.cpp
hphp/compiler/expression/expression_list.cpp
hphp/compiler/expression/scalar_expression.cpp
hphp/runtime/base/apc-object.cpp
hphp/runtime/base/builtin-functions.cpp
hphp/runtime/base/concurrent-shared-store.cpp
hphp/runtime/base/enum-cache.cpp
hphp/runtime/base/file-repository.cpp
hphp/runtime/base/type-array.cpp
hphp/runtime/base/type-string.h
hphp/runtime/base/type-variant.cpp
hphp/runtime/base/type-variant.h
hphp/runtime/base/variable-serializer.cpp
hphp/runtime/debugger/cmd/cmd_heaptrace.cpp
hphp/runtime/debugger/cmd/cmd_next.cpp
hphp/runtime/ext/asio/blockable_wait_handle.cpp
hphp/runtime/ext/ext_apc.cpp
hphp/runtime/ext/ext_array.cpp
hphp/runtime/ext/ext_class.cpp
hphp/runtime/ext/ext_fb.cpp
hphp/runtime/ext/ext_network.cpp
hphp/runtime/ext/ext_session.cpp
hphp/runtime/ext/ext_spl.cpp
hphp/runtime/ext/ext_string.cpp
hphp/runtime/ext/icu/ext_icu_break_iterator.h
hphp/runtime/ext/icu/ext_icu_locale.cpp
hphp/runtime/ext/icu/ext_icu_misc.cpp
hphp/runtime/ext/icu/ext_icu_ucsdet.cpp
hphp/runtime/ext/icu/icu.cpp
hphp/runtime/ext/json/ext_json.cpp
hphp/runtime/ext/stream/ext_stream-user-filters.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_API.cpp
hphp/runtime/ext_zend_compat/php-src/ext/standard/var.cpp
hphp/runtime/ext_zend_compat/php-src/main/php_globals.cpp
hphp/runtime/ext_zend_compat/php-src/main/php_streams.cpp
hphp/runtime/ext_zend_compat/php-src/main/streams/streams.cpp
hphp/runtime/server/http-protocol.cpp
hphp/runtime/server/request-uri.cpp
hphp/runtime/server/transport.cpp
hphp/runtime/vm/blob-helper.h
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/func.cpp
hphp/runtime/vm/jit/translator-runtime.cpp
hphp/runtime/vm/repo-helpers.cpp
hphp/runtime/vm/runtime-type-profiler.cpp
hphp/test/ext/test_cpp_base.cpp