| commit | cae1661eadd1becd4e98c978e8ae0d3f58696083 | |
| author | Rick Lavoie <rlavoie@fb.com> | |
| Tue, 20 Oct 2020 15:42:08 +0000 (20 08:42 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 20 Oct 2020 15:45:05 +0000 (20 08:45 -0700) | ||
| tree | b0ea748a9b9667179c4176cc98305554af6a3857 | treesnapshot (tar.gz zip) |
| parent | 0a48695db5ceb7e41d19ef4f0cd552536d34390d | commitdiff |
Deflake unit-cache-hash Unit test
Summary:
I've noticed this test (very rarely) failing spuriously. One
of the things it tries to do is create a Unit with a different SHA1,
but identical HHAS (to exercise the reuse logic in the unit-cache). It
seems that there's some non-determinism in HackC which means that
occasionally the HHAS will be different, causing the test to fail (the
Unit is not reused). Remove this portion of the test
Reviewed By: paulbiss
Differential Revision: D24413759
fbshipit-source-id: 1994bfdf73493e18470c73cef30505722630568c
Summary:
I've noticed this test (very rarely) failing spuriously. One
of the things it tries to do is create a Unit with a different SHA1,
but identical HHAS (to exercise the reuse logic in the unit-cache). It
seems that there's some non-determinism in HackC which means that
occasionally the HHAS will be different, causing the test to fail (the
Unit is not reused). Remove this portion of the test
Reviewed By: paulbiss
Differential Revision: D24413759
fbshipit-source-id: 1994bfdf73493e18470c73cef30505722630568c
| hphp/test/slow/unit-cache-hash.php | diffblobblamehistory | |
| hphp/test/slow/unit-cache-hash.php.expectf | diffblobblamehistory | |
| hphp/test/slow/unit-cache-hash.php.opts | diffblobblamehistory |