| commit | ca39827e0a93ef220fa6cf564c6655f1c01f6175 | |
| author | Katy Voor <voork@fb.com> | |
| Fri, 12 Feb 2021 04:26:02 +0000 (11 20:26 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 12 Feb 2021 04:28:12 +0000 (11 20:28 -0800) | ||
| tree | f1aaef99938261c6eb6a19e8c17f7f8b350bfa1a | treesnapshot (tar.gz zip) |
| parent | 0079e1aec358254f79c65ec0073b82507252abae | commitdiff |
Add ReadonlyOp to MemberKey for member operation bytecodes 2/2
Summary:
Add ReadonlyOp immediate to bytecodes in MemberKey argument.
```
- {SetM, QueryM, IncDecM, SetOpM, Dim}
```
- Since we pack it into the MemberKey, the `UnsetM` bytecode contains a `ReadonlyOp` as well.
- ReadonlyOp -> ReadOnlyOp per nit on prev diff and precedent of Pascal Case for other immediates.
ReadonlyOp can be `{ReadOnly, Mutable, Any}`
Emit dummy value `Any` for now from HackC.
Reviewed By: ricklavoie
Differential Revision: D26389393
fbshipit-source-id: 9f335e6c89a9a9ea52b90c678e65853d6e3d14eb
Summary:
Add ReadonlyOp immediate to bytecodes in MemberKey argument.
```
- {SetM, QueryM, IncDecM, SetOpM, Dim}
```
- Since we pack it into the MemberKey, the `UnsetM` bytecode contains a `ReadonlyOp` as well.
- ReadonlyOp -> ReadOnlyOp per nit on prev diff and precedent of Pascal Case for other immediates.
ReadonlyOp can be `{ReadOnly, Mutable, Any}`
Emit dummy value `Any` for now from HackC.
Reviewed By: ricklavoie
Differential Revision: D26389393
fbshipit-source-id: 9f335e6c89a9a9ea52b90c678e65853d6e3d14eb
31 files changed: