Move check to dissallow passing properties by ref from parser error to typeing error
commitc96e036af017a213cb407c6929c4d48fa33e9035
authorMartin Booth <martinbooth@fb.com>
Fri, 5 Apr 2019 20:11:11 +0000 (5 13:11 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 5 Apr 2019 20:14:47 +0000 (5 13:14 -0700)
tree06df3e2dab814a2af68c27e4df5ea93c30589298
parent5543eb2f765eb3fd988a899cc3797d30a8057b48
Move check to dissallow passing properties by ref from parser error to typeing error

Summary: In order to be able to fixme this type of error it cannot be a parser error

Reviewed By: kmeht

Differential Revision: D14790653

fbshipit-source-id: f2422ab67662d75d206ee2cf02becacdeabd02ed
22 files changed:
hphp/hack/src/errors/error_codes.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/hh_parse.ml
hphp/hack/src/hh_single_type_check.ml
hphp/hack/src/options/globalOptions.ml
hphp/hack/src/options/globalOptions.mli
hphp/hack/src/options/parserOptions.ml
hphp/hack/src/options/typecheckerOptions.ml
hphp/hack/src/parser/full_fidelity_parser_errors.ml
hphp/hack/src/parser/full_fidelity_syntax_error.ml
hphp/hack/src/parser/full_fidelity_syntax_error.mli
hphp/hack/src/server/serverConfig.ml
hphp/hack/src/typing/nast_check/inout_check.ml
hphp/hack/test/errors/error_map.ml
hphp/hack/test/full_fidelity/cases/reference_property.flags [deleted file]
hphp/hack/test/full_fidelity/cases/reference_property.php [deleted file]
hphp/hack/test/full_fidelity/cases/reference_property.php.errors.exp [deleted file]
hphp/hack/test/full_fidelity/cases/reference_property.php.sexp.exp [deleted file]
hphp/hack/test/typecheck/references/pass_by_ref/HH_FLAGS
hphp/hack/test/typecheck/references/pass_by_ref/byref_on_property.php [new file with mode: 0644]
hphp/hack/test/typecheck/references/pass_by_ref/byref_on_property.php.exp [new file with mode: 0644]