| commit | c9351783ac5e5b9bb03a94740fdad03d6529a6eb | |
| author | Arun Kumar <arkumar@fb.com> | |
| Tue, 7 Nov 2017 11:55:23 +0000 (7 03:55 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 7 Nov 2017 12:15:21 +0000 (7 04:15 -0800) | ||
| tree | d45a67e64b466f5f3c136e24d6f7b7345878f1a7 | treesnapshot (tar.gz zip) |
| parent | 3e68e10049b49c141f9c2182c079e1fa61c7f855 | commitdiff |
Fix semdiff syntactic output
Summary:
Motivation:
The syntactic diff was inverting the differences when reporting edits. For example, a deletion in the first file was reported as an addition.
Cause:
When parsing the arguments, we add the files in reverse order to !files.
Fix:
Before adding the two files to the `files` field in the `options` record, we swap the ordering.
Reviewed By: nbenton
Differential Revision: D6258698
fbshipit-source-id: 0546983bc926e2de94dc5343fa47c995e40b22ac
Summary:
Motivation:
The syntactic diff was inverting the differences when reporting edits. For example, a deletion in the first file was reported as an addition.
Cause:
When parsing the arguments, we add the files in reverse order to !files.
Fix:
Before adding the two files to the `files` field in the `options` record, we swap the ordering.
Reviewed By: nbenton
Differential Revision: D6258698
fbshipit-source-id: 0546983bc926e2de94dc5343fa47c995e40b22ac
27 files changed: