| commit | c8c04bc5ff29863464377e988c8ee72c2c89debb | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Fri, 16 Apr 2021 02:48:13 +0000 (15 19:48 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 16 Apr 2021 02:49:28 +0000 (15 19:49 -0700) | ||
| tree | e953ed928abb6113181885c5f2c08a64b7cce376 | treesnapshot (tar.gz zip) |
| parent | 351d7476ec0b7410a16a4ea24fcff18a34523344 | commitdiff |
Introduce TopStructLayout
Summary:
Introduce this abstract layout. It passes is_struct, so we can use LdStructDictElem and StructDictSet with it; modify those irlower routines to handle the abstract case. (We want to include the abstract layout in is_struct to match other predicates like "monotype", where it's essential; adding it in is not a problem because any caller that wants to limit to concrete StructLayout can still do so.)
Add type inference for TopStructLayout, extending StructLayout and fixing bugs while we're at it. For example, StructLayout::elemType would incorrectly return TBottom if its keyType couldBe TInt. It's safe because we don't have mixed key inputs for any of these ops, but we should fix it. Please review these changes carefully.
Add layout selection for TopStructLayout. We now will probabilistically specialize sinks to either a specific struct layout or to the top struct layout, even if they include some non-struct inputs.
Reviewed By: colavitam
Differential Revision: D27767113
fbshipit-source-id: fdd7255244aef59a9ae8edb494e4b6a31bdb571a
Summary:
Introduce this abstract layout. It passes is_struct, so we can use LdStructDictElem and StructDictSet with it; modify those irlower routines to handle the abstract case. (We want to include the abstract layout in is_struct to match other predicates like "monotype", where it's essential; adding it in is not a problem because any caller that wants to limit to concrete StructLayout can still do so.)
Add type inference for TopStructLayout, extending StructLayout and fixing bugs while we're at it. For example, StructLayout::elemType would incorrectly return TBottom if its keyType couldBe TInt. It's safe because we don't have mixed key inputs for any of these ops, but we should fix it. Please review these changes carefully.
Add layout selection for TopStructLayout. We now will probabilistically specialize sinks to either a specific struct layout or to the top struct layout, even if they include some non-struct inputs.
Reviewed By: colavitam
Differential Revision: D27767113
fbshipit-source-id: fdd7255244aef59a9ae8edb494e4b6a31bdb571a