| commit | c75bae5af30f52e7f24830f085279383d27a6295 | |
| author | Owen Yamauchi <oyamauchi@fb.com> | |
| Thu, 1 Aug 2013 01:53:39 +0000 (31 18:53 -0700) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Mon, 5 Aug 2013 21:42:13 +0000 (5 14:42 -0700) | ||
| tree | 63671f15254b2c5197e00c336cd3bcc725bbd2e4 | treesnapshot (tar.gz zip) |
| parent | aba544ba90f117522a0f2d10620459ef7501427a | commitdiff |
Delete atomic_inc
This was a little weird: I deleted the definition first, and everything
compiled because all the usages now are behind ifdefs that we don't test
regularly. In the interest of not ruffling feathers over deleting this
code, I just went ahead and made the changes. I would like to suggest
deleting all this stuff, especially the GOOGLE_HEAP_PROFILER stuff, for
which the make target has been deleted for a long time.
Again, all the usage sites are using the default memory order specifier,
which is memory_order_seq_cst. They could stand to be relaxed, but I
didn't find it worthwhile.
I'd also like to replace atomic_acquire_load and atomic_release_store
with portable and correct alternatives. We really just shouldn't be
rolling our own atomic primitives.
Differential Revision: D909903
This was a little weird: I deleted the definition first, and everything
compiled because all the usages now are behind ifdefs that we don't test
regularly. In the interest of not ruffling feathers over deleting this
code, I just went ahead and made the changes. I would like to suggest
deleting all this stuff, especially the GOOGLE_HEAP_PROFILER stuff, for
which the make target has been deleted for a long time.
Again, all the usage sites are using the default memory order specifier,
which is memory_order_seq_cst. They could stand to be relaxed, but I
didn't find it worthwhile.
I'd also like to replace atomic_acquire_load and atomic_release_store
with portable and correct alternatives. We really just shouldn't be
rolling our own atomic primitives.
Differential Revision: D909903