| commit | c756da9affe793b49a509aa1fd40813b7d9b9a87 | |
| author | Mark Williams <mwilliams@fb.com> | |
| Tue, 6 Oct 2015 02:14:19 +0000 (5 19:14 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Tue, 6 Oct 2015 02:30:45 +0000 (5 19:30 -0700) | ||
| tree | 70739c1b45ed3089f0b01fb370d36e21cdadfc7f | treesnapshot (tar.gz zip) |
| parent | 20c8f33f683ce5dd3a4b27d8fbab921556d7c9c9 | commitdiff |
Fix ClassicWriter
Summary: D2277170 refactored access log handling, and as an optimization, I
suggested dropping the ostringstream, and writing directly.
This broke the atomicity of log lines; we could have lines from
different threads interleaved, which messes up the logs
Reviewed By: @mxw
Differential Revision: D2509891
fb-gh-sync-id: d96eea3e5d6aaa94533a0190790f9262a0f04897
Summary: D2277170 refactored access log handling, and as an optimization, I
suggested dropping the ostringstream, and writing directly.
This broke the atomicity of log lines; we could have lines from
different threads interleaved, which messes up the logs
Reviewed By: @mxw
Differential Revision: D2509891
fb-gh-sync-id: d96eea3e5d6aaa94533a0190790f9262a0f04897
| hphp/runtime/server/log-writer.cpp | diffblobblamehistory |