| commit | c6a786d0a809a7eb3a827be6981787803242bb7b | |
| author | Ian Hoffman <ianhoffman10@gmail.com> | |
| Wed, 2 Feb 2022 02:15:16 +0000 (1 18:15 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 2 Feb 2022 02:16:54 +0000 (1 18:16 -0800) | ||
| tree | 9956761dd3738c8d93fe7b24254dff68f6869a20 | treesnapshot (tar.gz zip) |
| parent | 670d9e705795dc4c0d6c795fd19b931426278db2 | commitdiff |
Improve error messages for bad method visibility (#8961)
Summary:
Closes https://github.com/facebook/hhvm/issues/8959
The biggest trouble I ran into working on this was getting my dev environment configured. I built HHVM in a docker container using docker-compose and mutagen to handle file-syncing with the container. This mostly worked, except for the files generated by `review.sh`: I had to manually copy them out of the container for some reason. Not sure why they didn't sync to the host automatically.
Just curious - what setup do people at FB use for Hack development? Do y'all build locally? And if you use docker or some other remote setup, do you sync VSCode (or some other IDE?) to an LSP running there?
I should probably take these questions over to Slack.
Pull Request resolved: https://github.com/facebook/hhvm/pull/8961
Reviewed By: shayne-fletcher
Differential Revision: D33857025
Pulled By: Wilfred
fbshipit-source-id: a8d0fc932ff2df719d9b9103b77aa2150419248b
Summary:
Closes https://github.com/facebook/hhvm/issues/8959
The biggest trouble I ran into working on this was getting my dev environment configured. I built HHVM in a docker container using docker-compose and mutagen to handle file-syncing with the container. This mostly worked, except for the files generated by `review.sh`: I had to manually copy them out of the container for some reason. Not sure why they didn't sync to the host automatically.
Just curious - what setup do people at FB use for Hack development? Do y'all build locally? And if you use docker or some other remote setup, do you sync VSCode (or some other IDE?) to an LSP running there?
I should probably take these questions over to Slack.
Pull Request resolved: https://github.com/facebook/hhvm/pull/8961
Reviewed By: shayne-fletcher
Differential Revision: D33857025
Pulled By: Wilfred
fbshipit-source-id: a8d0fc932ff2df719d9b9103b77aa2150419248b
25 files changed: