| commit | c51d6751d8f72321344790a418f6e01511963b95 | |
| author | Quentin Carbonneaux <qcar@fb.com> | |
| Tue, 16 Aug 2022 11:46:06 +0000 (16 04:46 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 16 Aug 2022 11:46:06 +0000 (16 04:46 -0700) | ||
| tree | 607b66b001651553171901c86240b9dab3cc6115 | treesnapshot (tar.gz zip) |
| parent | fe0f9990f877f1ff62a0569054e6920438234700 | commitdiff |
Remove two redundant tests
Summary:
The two tests were introduced in D38021571 (https://github.com/facebook/hhvm/commit/2912cd4932f8f91c26b9ab6ef7a3c772015b386b), but they
block me landing D37280849 because they use loose
refinements that will (initially) fail to localize.
To avoid losing any coverage, the two tests could be
moved from test/typecheck to test/nast. However,
they would then be largely redundant with
test/nast/type-refinement.php; justifying the
deletions in this diff.
Reviewed By: strub-meta
Differential Revision: D38737896
fbshipit-source-id: a695e94e5cfb155719802943cbd971d5bacb025b
Summary:
The two tests were introduced in D38021571 (https://github.com/facebook/hhvm/commit/2912cd4932f8f91c26b9ab6ef7a3c772015b386b), but they
block me landing D37280849 because they use loose
refinements that will (initially) fail to localize.
To avoid losing any coverage, the two tests could be
moved from test/typecheck to test/nast. However,
they would then be largely redundant with
test/nast/type-refinement.php; justifying the
deletions in this diff.
Reviewed By: strub-meta
Differential Revision: D38737896
fbshipit-source-id: a695e94e5cfb155719802943cbd971d5bacb025b