| commit | c4f105fe5088771e07336b088160f722324a371b | |
| author | Hunter Goldstein <hgoldstein@meta.com> | |
| Tue, 14 Feb 2023 00:34:46 +0000 (13 16:34 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 14 Feb 2023 00:34:46 +0000 (13 16:34 -0800) | ||
| tree | c235e872dfd6319a9e6d70a74c6889aefda0e42c | treesnapshot (tar.gz zip) |
| parent | dabd389da143d08396d62c4d4de88ff98b9330bb | commitdiff |
Manually fix or remove runtime tests with `fun`, `class_meth`, or `inst_meth`
Summary:
`fun`, `class_meth`, and `inst_meth` ought to be properly ripped out of Hack. The steps here are roughly:
1. Codemod away the syntax from tests (we are here)
2. Default the options for disabling these at the parser level to `on`
3. Rip out the typechecker & compiler support
4. Relax the parser rules in (2)
This diff manually handles `fun`, `class_meth`, and some `inst_meth` tests. Any that are no longer relevant (e.g.: testing syntactic forms that are impossible under function pointers) are just removed.
Reviewed By: periodic1236
Differential Revision: D42255399
fbshipit-source-id: 87843f35113dc89a00080c1d2c72f9b730abff25
Summary:
`fun`, `class_meth`, and `inst_meth` ought to be properly ripped out of Hack. The steps here are roughly:
1. Codemod away the syntax from tests (we are here)
2. Default the options for disabling these at the parser level to `on`
3. Rip out the typechecker & compiler support
4. Relax the parser rules in (2)
This diff manually handles `fun`, `class_meth`, and some `inst_meth` tests. Any that are no longer relevant (e.g.: testing syntactic forms that are impossible under function pointers) are just removed.
Reviewed By: periodic1236
Differential Revision: D42255399
fbshipit-source-id: 87843f35113dc89a00080c1d2c72f9b730abff25
27 files changed: