| commit | c1d638ade5fd0f102b3858ad0a1fe566fba201fd | |
| author | Eric Bluestein <ericblue@fb.com> | |
| Thu, 28 Dec 2017 06:17:54 +0000 (27 22:17 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 28 Dec 2017 06:33:27 +0000 (27 22:33 -0800) | ||
| tree | c94fe0a6ca394c330d9e759b069a8e6bfbe614a3 | treesnapshot (tar.gz zip) |
| parent | 23406d0379de3c29a4b1a52e2a0d1e47187dbf52 | commitdiff |
Fix HHVM not hitting certain breakpoints
Summary: HHVM is not hitting breakpoints put on lines with multiple opcodes if the first opcode of the line is not executed by the interpreter. This is because the PC of the first opcode in the line is added to the line breakpoints PC filter, but the subsequent opcodes are not. We'll therefore only hit the breakpoint if the PC lands on the first opcode in the line, and miss it if we jump elsewhere in the range.
Reviewed By: rightparen
Differential Revision: D6455132
fbshipit-source-id: ac520763fd5b90f0b6ad1a2d81957ec7a20c786a
Summary: HHVM is not hitting breakpoints put on lines with multiple opcodes if the first opcode of the line is not executed by the interpreter. This is because the PC of the first opcode in the line is added to the line breakpoints PC filter, but the subsequent opcodes are not. We'll therefore only hit the breakpoint if the PC lands on the first opcode in the line, and miss it if we jump elsewhere in the range.
Reviewed By: rightparen
Differential Revision: D6455132
fbshipit-source-id: ac520763fd5b90f0b6ad1a2d81957ec7a20c786a
| hphp/runtime/vm/debugger-hook.cpp | diffblobblamehistory |