| commit | c1c1f81ad03f34c0ce7e39295393be5092ed30d4 | |
| author | Alex Malyshev <alexanderm@fb.com> | |
| Sat, 29 Nov 2014 22:45:51 +0000 (29 14:45 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Sat, 29 Nov 2014 23:00:33 +0000 (29 15:00 -0800) | ||
| tree | 2384c01bda5bd76a1e23827c100b9dd9bf4c0208 | treesnapshot (tar.gz zip) |
| parent | bc135b8b5a42c001faf793f54bce28b50b6d348e | commitdiff |
Improve the property accessing API of Class.
Summary: Affects Class methods getDeclPropIndex(), findSProp(), getSProp(), and
zGetSProp(). They were taking two boolean arguments by reference and setting
them: visible and accessible.
visible is unneeded. It was set iff the property existed, but that could be
checked against the return values of those functions (either "value == nullptr"
or "slotIdx == kInvalidInd").
That left returning a some representation of the property (either a Slot,
TypedValue*, or RefData*) and the accessible flag, which I turned into a struct
templated on the property.
Reviewed By: @jdelong
Differential Revision: D1708784
Signature: t1:1708784:1417282914:1782c28704245b9b2a50520936dcabc155e13a77
Summary: Affects Class methods getDeclPropIndex(), findSProp(), getSProp(), and
zGetSProp(). They were taking two boolean arguments by reference and setting
them: visible and accessible.
visible is unneeded. It was set iff the property existed, but that could be
checked against the return values of those functions (either "value == nullptr"
or "slotIdx == kInvalidInd").
That left returning a some representation of the property (either a Slot,
TypedValue*, or RefData*) and the accessible flag, which I turned into a struct
templated on the property.
Reviewed By: @jdelong
Differential Revision: D1708784
Signature: t1:1708784:1417282914:1782c28704245b9b2a50520936dcabc155e13a77