Use types from the oxidized_by_ref crate instead of the oxidized crate for to_oxidized
commitc10171c4332032fcc52ea1d06d79f51a09a85fb8
authorJake Bailey (Hacklang) <jakebailey@fb.com>
Fri, 29 May 2020 05:17:27 +0000 (28 22:17 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 29 May 2020 05:33:56 +0000 (28 22:33 -0700)
treef9218babb70fc72991e5f69c0e055dffa5619263
parentd2606fb1e5548f85addac1e6f6b97eafa422ce2b
Use types from the oxidized_by_ref crate instead of the oxidized crate for to_oxidized

Summary: This diff replaces the use of the oxidized typechecker types in `to_oxidized`, replacing them with oxidized_by_ref definitions. This unblocks deleting typechecker types and decls from the oxidized crate, since they are used only in this debugging-only path. It also reduces the amount of conversion necessary for `to_oxidized` (since we need not convert the oxidized_by_ref structures the typechecker already uses, like `Ty`).

Differential Revision: D21587518

fbshipit-source-id: 5e7ec2237d0059070653b45d15eb7c1259588ccb
34 files changed:
hphp/hack/Cargo.lock
hphp/hack/src/hh_oxidize/convert_type.ml
hphp/hack/src/hh_oxidize/convert_type_decl.ml
hphp/hack/src/oxidized_by_ref/Cargo.toml
hphp/hack/src/oxidized_by_ref/extern_types.txt
hphp/hack/src/oxidized_by_ref/gen/mod.rs
hphp/hack/src/oxidized_by_ref/gen/typing_cont_key.rs
hphp/hack/src/oxidized_by_ref/gen/typing_env_return_info.rs [copied from hphp/hack/src/oxidized_by_ref/gen/typing_cont_key.rs with 61% similarity]
hphp/hack/src/oxidized_by_ref/gen/typing_env_types.rs
hphp/hack/src/oxidized_by_ref/gen/typing_local_types.rs
hphp/hack/src/oxidized_by_ref/lib.rs
hphp/hack/src/oxidized_by_ref/manual/ast_defs_impl.rs
hphp/hack/src/oxidized_by_ref/manual/decl_env.rs [copied from hphp/hack/src/typing/typing_reason.rs with 57% similarity]
hphp/hack/src/oxidized_by_ref/manual/lazy.rs [new file with mode: 0644]
hphp/hack/src/oxidized_by_ref/manual/local_id.rs
hphp/hack/src/oxidized_by_ref/manual/mod.rs
hphp/hack/src/oxidized_by_ref/manual/pos.rs
hphp/hack/src/oxidized_by_ref/manual/typing_defs_core_impl.rs
hphp/hack/src/oxidized_by_ref/manual/typing_reason.rs
hphp/hack/src/oxidized_by_ref/regen.sh
hphp/hack/src/typing/cargo/typing_rust/Cargo.toml
hphp/hack/src/typing/typing.rs
hphp/hack/src/typing/typing_continuations.rs [copied from hphp/hack/src/typing/typing_reason.rs with 57% similarity]
hphp/hack/src/typing/typing_defs_core.rs
hphp/hack/src/typing/typing_env.rs
hphp/hack/src/typing/typing_env_from_def.rs
hphp/hack/src/typing/typing_env_types.rs
hphp/hack/src/typing/typing_inference_env.rs
hphp/hack/src/typing/typing_local_types.rs
hphp/hack/src/typing/typing_make_type.rs
hphp/hack/src/typing/typing_per_cont_env.rs
hphp/hack/src/typing/typing_phase.rs
hphp/hack/src/typing/typing_reason.rs
hphp/hack/src/typing/typing_solver.rs