Check argument to 'unset' in reactive mode
commitc0dca792384835c658af5ef4121f980d42e42390
authorVladimir Matveev <vladima@fb.com>
Mon, 16 Jul 2018 19:06:34 +0000 (16 12:06 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Mon, 16 Jul 2018 19:13:01 +0000 (16 12:13 -0700)
tree70178443303ad881df1bf4add896c8984040eaab
parent2fce85c6fdf7d6fcc3fcb01efd87ae754457464a
Check argument to 'unset' in reactive mode

Summary: Apply the same check we currently have for assignment targets to arguments of 'unset'

Reviewed By: DavidSnider

Differential Revision: D8860828

fbshipit-source-id: ba4de138f66fd5e4c40af8f7182944cd5bfcd6bc
19 files changed:
hphp/hack/src/errors/error_codes.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors_sig.ml
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_mutability.ml
hphp/hack/src/typing/typing_mutability.mli
hphp/hack/test/errors/error_map.ml
hphp/hack/test/typecheck/reactive/unset_rx1.php [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx1.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx2.php [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx2.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx3.php [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx3.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx4.php [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx4.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx5.php [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx5.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx6.php [new file with mode: 0644]
hphp/hack/test/typecheck/reactive/unset_rx6.php.exp [new file with mode: 0644]