| commit | be5c755780e52193e00d55cca9475381b3913c35 | |
| author | aude <aude.wiki@gmail.com> | |
| Fri, 15 Aug 2014 22:07:14 +0000 (15 15:07 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Fri, 15 Aug 2014 22:30:18 +0000 (15 15:30 -0700) | ||
| tree | 1f58c071bda09bccd5384840c3fcec133d717ba6 | treesnapshot (tar.gz zip) |
| parent | 930318889f94c5f84c7f00515275edc44b6035e3 | commitdiff |
ArrayObject::append() should delegate to ArrayObject::offsetSet()
Summary: Match php5 implementation by delegating rather than direct manipulation of internal state.
Fixes issue #3403.
Closes https://github.com/facebook/hhvm/pull/3404
Reviewed By: @fredemmott
Differential Revision: D1486300
Pulled By: svcscm
Summary: Match php5 implementation by delegating rather than direct manipulation of internal state.
Fixes issue #3403.
Closes https://github.com/facebook/hhvm/pull/3404
Reviewed By: @fredemmott
Differential Revision: D1486300
Pulled By: svcscm
| hphp/system/php/spl/miscellaneous/ArrayObject.php | diffblobblamehistory | |
| hphp/test/slow/array_object/append.php | diffblobblamehistory | |
| hphp/test/slow/array_object/append.php.expect | diffblobblamehistory |