| commit | bd59bca6a17eade1f4e2cbb2555a02e5583ddb5d | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Wed, 10 Jun 2020 03:04:57 +0000 (9 20:04 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 10 Jun 2020 03:07:29 +0000 (9 20:07 -0700) | ||
| tree | 0a104eafa8c2ae75444ab583920583f5df5ecd18 | treesnapshot (tar.gz zip) |
| parent | 0438a75785cc23e9403a7cb633aeee3ea59bab2a | commitdiff |
Update kind on conversion
Summary:
From the slow bespoke tests, another easy correctness fix: when we perform a conversion op on a LoggingArray and get the same inner array back, we may still have changed its kind (e.g. packed -> vec) and must change the outer array's kind too. This issue doesn't happen for packed to mixed because it's always a new array in that case.
m_kind is protected, so I added a helper method that does the update.
Reviewed By: jano
Differential Revision: D21964056
fbshipit-source-id: 6e0af880a534210da363c0b0bd55a848a4ba5a44
Summary:
From the slow bespoke tests, another easy correctness fix: when we perform a conversion op on a LoggingArray and get the same inner array back, we may still have changed its kind (e.g. packed -> vec) and must change the outer array's kind too. This issue doesn't happen for packed to mixed because it's always a new array in that case.
m_kind is protected, so I added a helper method that does the update.
Reviewed By: jano
Differential Revision: D21964056
fbshipit-source-id: 6e0af880a534210da363c0b0bd55a848a4ba5a44
| hphp/runtime/base/bespoke/logging-array.cpp | diffblobblamehistory | |
| hphp/runtime/base/bespoke/logging-array.h | diffblobblamehistory |