Add catch blocks to more Concat instructions, fix refcount opts bug
commitbcebd089309d6c35f3edda173b33e3f153267b75
authorbsimmers <bsimmers@fb.com>
Thu, 20 Feb 2014 17:46:54 +0000 (20 09:46 -0800)
committerSara Golemon <sgolemon@fb.com>
Fri, 21 Feb 2014 14:52:21 +0000 (21 06:52 -0800)
treef86aad829f200459c2265f28521ad14a8bb716a9
parente62d1110ee37b506e06af0b874628b0682109559
Add catch blocks to more Concat instructions, fix refcount opts bug

- NativeImpl consumes all locals so we need to treat it like
  GenericRetDecRefs.
- String concatenation can throw if the result would be too large.

Reviewed By: @jasone

Differential Revision: D1182537
hphp/runtime/vm/jit/ir.h
hphp/runtime/vm/jit/refcount-opts.cpp
hphp/runtime/vm/jit/simplifier.cpp