| commit | bc376a7e7ac5b7e90d79ece7160624f65f403922 | |
| author | Ted Spence <tspence@fb.com> | |
| Wed, 15 May 2019 15:43:58 +0000 (15 08:43 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 15 May 2019 15:51:20 +0000 (15 08:51 -0700) | ||
| tree | 02827621fa85c940f54085820e8683a117c91b3a | treesnapshot (tar.gz zip) |
| parent | 57cb8ea0911c747b2ffe18736afc1892e10955ad | commitdiff |
Clean up glean export
Summary:
Re-running the glean export today, I notice that some of the logs and error messages are hard to read.
* Finish replacing all Printf commands with Hh_logger commands.
* Remove all newlines and flush-buffer commands, which are no longer needed since we're now using Hh_logger instead of printf.
* I notice that we're not actually printing the full error messages anywhere. Make it possible to read these by emitting the full error list.
* I notice that if you fail to export to json, the command does nothing. It should really explain why.
* Also, Globalrev is a facebook concept. It doesn't need to exist in the open source part of this program. I'll move it from the main program into the glean specific exporter.
Reviewed By: rleshchinskiy
Differential Revision: D15320006
fbshipit-source-id: 9237ae415906505476f201381e4509435861b0e2
Summary:
Re-running the glean export today, I notice that some of the logs and error messages are hard to read.
* Finish replacing all Printf commands with Hh_logger commands.
* Remove all newlines and flush-buffer commands, which are no longer needed since we're now using Hh_logger instead of printf.
* I notice that we're not actually printing the full error messages anywhere. Make it possible to read these by emitting the full error list.
* I notice that if you fail to export to json, the command does nothing. It should really explain why.
* Also, Globalrev is a facebook concept. It doesn't need to exist in the open source part of this program. I'll move it from the main program into the glean specific exporter.
Reviewed By: rleshchinskiy
Differential Revision: D15320006
fbshipit-source-id: 9237ae415906505476f201381e4509435861b0e2
| hphp/hack/src/facts/symbols/customSymbolIndexWriter.ml | diffblobblamehistory | |
| hphp/hack/src/facts/symbols/indexBuilder.ml | diffblobblamehistory |