| commit | bbb710c25bea007ebaa26c6e0fef1bc943993b62 | |
| author | Jeffrey Tan <jeffreytan@fb.com> | |
| Thu, 9 Apr 2020 01:24:32 +0000 (8 18:24 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 9 Apr 2020 01:41:38 +0000 (8 18:41 -0700) | ||
| tree | b9717a076bab34f321cd43349bae7babc00fa2e1 | treesnapshot (tar.gz zip) |
| parent | b5d484fee92a858115d825ca1741e561dd1963ee | commitdiff |
Fix naming table downloading failure due to deleted files
Summary:
Last diff I used `Disk.cat` as a synchronous replacement for `Lwt_utils.read_all`, turns out it did not handle the deleted files cases.
This diff fixed it by using `File_provider.get_contents` which correctly handles deleted files.
Reviewed By: 2BitSalute
Differential Revision: D20930927
fbshipit-source-id: 7857ae20bae4f3aa497f7fdc74fd7a387b545ef9
Summary:
Last diff I used `Disk.cat` as a synchronous replacement for `Lwt_utils.read_all`, turns out it did not handle the deleted files cases.
This diff fixed it by using `File_provider.get_contents` which correctly handles deleted files.
Reviewed By: 2BitSalute
Differential Revision: D20930927
fbshipit-source-id: 7857ae20bae4f3aa497f7fdc74fd7a387b545ef9
| hphp/hack/src/client/ide_service/clientIdeIncremental.ml | diffblobblamehistory |