Hack arrays should only serialize under VariantControllerHackArraysMode::ON
commitbb8e8e338c3ad7964b8ec51acef3cfd8e04107b5
authorKevin Viratyosin <viratyosin@fb.com>
Wed, 26 Jun 2019 15:31:45 +0000 (26 08:31 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Wed, 26 Jun 2019 15:36:34 +0000 (26 08:36 -0700)
tree89b5aef238087b9c7daac63fcceeabab16346742
parent308a25f0610de9dd1dbe144d947d47dfad9ad180
Hack arrays should only serialize under VariantControllerHackArraysMode::ON

Summary:
* This mode is currently only used by the async tier framework which already checks against hack arrays (cc hgolstein)
* Deleted the DVArrs test b/c when this flag is on fb_serialize will need to branch on markedness which doens't exist yet (cc jjgriego)

Reviewed By: jjgriego

Differential Revision: D15904366

fbshipit-source-id: 3ac7829b486954db0ed7af6de176674aba3b6633
hphp/runtime/ext/fb/VariantController.h
hphp/test/slow/ext_fb/migratory_serialize.php
hphp/test/slow/ext_fb/migratory_serialize_hackarray.php [deleted file]
hphp/test/slow/ext_fb/migratory_serialize_hackarray.php.expect [deleted file]
hphp/test/slow/ext_fb/migratory_serialize_hackarray.php.hphp_opts [deleted file]
hphp/test/slow/ext_fb/migratory_serialize_hackarray.php.opts [deleted file]