| commit | bb2eff48dc3f0af9840538a5a8d44fe534d3f848 | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Sat, 19 Dec 2020 18:41:12 +0000 (19 10:41 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 19 Dec 2020 18:43:16 +0000 (19 10:43 -0800) | ||
| tree | 53fa3fa2d9450aef01dc2b0abb2a5cc870f1a1e6 | treesnapshot (tar.gz zip) |
| parent | 1ab2606dd9f7b471d49c0049215e554cc7cf2922 | commitdiff |
Fix automarking bug: counted type constants
Summary:
It turns out that the caching layers for is/as/reified TypeStructure resolution rely heavily on the fact that these structures are static arrays.
These structures are managed entirely by the runtime, so they should never be observed. We don't need to automark them. However, this bug is not a HADVAs bug - it's only a bug in the test strategy.
Reviewed By: ricklavoie
Differential Revision: D25651550
fbshipit-source-id: 1f4ee0b854ea83e7feae64124a4bc7fcf1037f03
Summary:
It turns out that the caching layers for is/as/reified TypeStructure resolution rely heavily on the fact that these structures are static arrays.
These structures are managed entirely by the runtime, so they should never be observed. We don't need to automark them. However, this bug is not a HADVAs bug - it's only a bug in the test strategy.
Reviewed By: ricklavoie
Differential Revision: D25651550
fbshipit-source-id: 1f4ee0b854ea83e7feae64124a4bc7fcf1037f03
| hphp/hack/src/hhbc/emit_expression.rs | diffblobblamehistory | |
| hphp/test/slow/is-expression/interp_oom.php.nohadva | [deleted file] | blobblamehistory |