| commit | b9b1d9f2ef32c35b5d916eb3e4466a156791de53 | |
| author | Edwin Smith <smith@meta.com> | |
| Thu, 12 Jan 2023 19:42:38 +0000 (12 11:42 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 12 Jan 2023 19:42:38 +0000 (12 11:42 -0800) | ||
| tree | 331b69f894b64ec7150fd60b57b763b2cbf9a8d3 | treesnapshot (tar.gz zip) |
| parent | 88bfd5e775dd6d97e0741f612736b5743dd6c9c7 | commitdiff |
type structure key names are case sensitive
Summary:
While auditing all calls to `isame()` I noticed this comparison is invalid;
TypeStructures are an ad-hoc ADT composed of shapes that
describe Hack types. the *keys* in those shapes are arraykeys that are
case sensitive names, such as `<type_structure>["classname"]`.
Reviewed By: ricklavoie
Differential Revision: D42456581
fbshipit-source-id: a8813afb4efd5d95ecf0e2fe9316f57f53826927
Summary:
While auditing all calls to `isame()` I noticed this comparison is invalid;
TypeStructures are an ad-hoc ADT composed of shapes that
describe Hack types. the *keys* in those shapes are arraykeys that are
case sensitive names, such as `<type_structure>["classname"]`.
Reviewed By: ricklavoie
Differential Revision: D42456581
fbshipit-source-id: a8813afb4efd5d95ecf0e2fe9316f57f53826927
| hphp/hhbbc/interp-minstr.cpp | diffblobblamehistory |