| commit | b84d93eb4a20463569dbdc142c41c14752f337fd | |
| author | Joel Marcey <joelm@fb.com> | |
| Tue, 12 Nov 2013 23:55:19 +0000 (12 15:55 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Wed, 13 Nov 2013 22:10:34 +0000 (13 14:10 -0800) | ||
| tree | a4fdb6681bb735e67ec0c5d8d9ec9d90f0592e78 | treesnapshot (tar.gz zip) |
| parent | d25f3414a7e9eecfb53dd33e527c40c9984b3010 | commitdiff |
Fix install bug after move to Framework classes
This bug basically prohibited the install of frameworks. Why? Because I was doing setXXX calls in the Framework constructor even if the framework wasn't installed. So I fixed that. To do this quickly, I removed the parallelization of multiple framework installs. But since the install should be rare, this quick fix is worth the time hit.
Failing flib tests have nothing to do with this script
Reviewed By: @ptarjan
Differential Revision: D1053633
This bug basically prohibited the install of frameworks. Why? Because I was doing setXXX calls in the Framework constructor even if the framework wasn't installed. So I fixed that. To do this quickly, I removed the parallelization of multiple framework installs. But since the install should be rare, this quick fix is worth the time hit.
Failing flib tests have nothing to do with this script
Reviewed By: @ptarjan
Differential Revision: D1053633
| hphp/test/frameworks/run.php | diffblobblamehistory |