Preemptively update tests for UndefinedVariableException 3/n
commitb8218cab82c2c9771afe60811f9b2e61df38a68e
authorKaty Voor <voork@fb.com>
Wed, 20 Jan 2021 20:51:35 +0000 (20 12:51 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 20 Jan 2021 20:54:43 +0000 (20 12:54 -0800)
tree647f43a4804dfff58bacd5f6242714588afc172e
parent43c2947ed2a74ec0746fdc40d9ddb03771c4d9c5
Preemptively update tests for UndefinedVariableException 3/n

Summary:
From summary 1/n:
- Would like to have UndefinedVariableException fatal in HHVM instead of thrown in www.
- There are ~500 tests, so in order to make code review possible, I'm breaking up tests before landing that change

These tests are checking an array of inputs on different functions. Since undefined variable will always throw an exception, it seem redundant to pull these arguments out of the array into a try catch for each test, and wouldn't test the function these tests are testing. So for these, we should remove undefined/unset args from the array of inputs to be tested.

- These changes were largely generated with sed, and are nearly all the same

Reviewed By: ricklavoie

Differential Revision: D25917053

fbshipit-source-id: 6207b2418bd115c2e7ec6fee5f9f77e5c71391f8
32 files changed:
hphp/test/zend/good/ext/iconv/tests/iconv_get_encoding_error.php
hphp/test/zend/good/ext/iconv/tests/iconv_get_encoding_error.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_headers_variation2.php
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_headers_variation2.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_headers_variation3.php
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_headers_variation3.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_variation1.php
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_variation1.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_variation2.php
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_variation2.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_variation3.php
hphp/test/zend/good/ext/iconv/tests/iconv_mime_decode_variation3.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_set_encoding_error.php
hphp/test/zend/good/ext/iconv/tests/iconv_set_encoding_error.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strlen_variation1.php
hphp/test/zend/good/ext/iconv/tests/iconv_strlen_variation1.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strlen_variation2.php
hphp/test/zend/good/ext/iconv/tests/iconv_strlen_variation2.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation1.php
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation1.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation2.php
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation2.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation3_64bit.php
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation3_64bit.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation4.php
hphp/test/zend/good/ext/iconv/tests/iconv_strpos_variation4.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strrpos_variation1.php
hphp/test/zend/good/ext/iconv/tests/iconv_strrpos_variation1.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strrpos_variation2.php
hphp/test/zend/good/ext/iconv/tests/iconv_strrpos_variation2.php.expectf
hphp/test/zend/good/ext/iconv/tests/iconv_strrpos_variation3.php
hphp/test/zend/good/ext/iconv/tests/iconv_strrpos_variation3.php.expectf