| commit | b5f289ba1a989621fb632712a03c027277b2ede1 | |
| author | Rick Lavoie <rlavoie@fb.com> | |
| Wed, 16 Sep 2015 14:15:28 +0000 (16 07:15 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Wed, 16 Sep 2015 14:30:35 +0000 (16 07:30 -0700) | ||
| tree | 5a153350206bb4ed0e708fc223882a4ba5abad69 | treesnapshot (tar.gz zip) |
| parent | 04efbb79698deb4ebdac96a5bf5b31aa81df17f7 | commitdiff |
Add support for PHP7 "spaceship" operator
Summary: Add support for the new PHP7 "spaceship" operator. The invokation "A
<=> B" compares A and B and returns -1 if A is less than B, 0 if they are
equal, and 1 if A is greater than B.
Supporting this involves adding a new bytecode instruction called "Cmp", as well
as a handful of new IR opcodes for each type. This utilizes most of the
machinery of the IR type-specific opcode conversion. Note that this operator
cannot be simply be de-sugared into a set of less-than and greater-than
operations, because that would be observable for types that invoke user code
during comparisons.
Closes https://github.com/facebook/hhvm/issues/5499
Reviewed By: @swtaarrs
Differential Revision: D2438952
Summary: Add support for the new PHP7 "spaceship" operator. The invokation "A
<=> B" compares A and B and returns -1 if A is less than B, 0 if they are
equal, and 1 if A is greater than B.
Supporting this involves adding a new bytecode instruction called "Cmp", as well
as a handful of new IR opcodes for each type. This utilizes most of the
machinery of the IR type-specific opcode conversion. Note that this operator
cannot be simply be de-sugared into a set of less-than and greater-than
operations, because that would be observable for types that invoke user code
during comparisons.
Closes https://github.com/facebook/hhvm/issues/5499
Reviewed By: @swtaarrs
Differential Revision: D2438952
40 files changed: