| commit | b5c7fd4d3b68a78df75861e363cc2dd99bd9f8c7 | |
| author | Victor Zverovich <viz@fb.com> | |
| Fri, 18 Oct 2019 15:56:19 +0000 (18 08:56 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 18 Oct 2019 15:58:25 +0000 (18 08:58 -0700) | ||
| tree | 22f2e0e51e63e4eb2eae03f4040341dea7b33e64 | treesnapshot (tar.gz zip) |
| parent | 5abe7aa53bf9abe78c9446c1a4c0b515eb37ec6e | commitdiff |
Make a field mutable and add message prefixes in thrift serializer
Summary:
Make the `prop` field mutable and pass `FieldInfo` by const reference per discussion in D16821721.
Also add `[Suppressed]` and `[Unsuppressed]` prefixes to warning messages to be able to distinguish the case of the error suppressed by an attribute from an unsuppressed one and from the warnings from old hhvm. This way we can figure out when all the problematic cases have been annotated with the new attribute and we can turn errors on by default.
Reviewed By: alexeyt
Differential Revision: D17866247
fbshipit-source-id: 39fb46f4ca3118a106f29f082f2c0ed260df67fd
Summary:
Make the `prop` field mutable and pass `FieldInfo` by const reference per discussion in D16821721.
Also add `[Suppressed]` and `[Unsuppressed]` prefixes to warning messages to be able to distinguish the case of the error suppressed by an attribute from an unsuppressed one and from the warnings from old hhvm. This way we can figure out when all the problematic cases have been annotated with the new attribute and we can turn errors on by default.
Reviewed By: alexeyt
Differential Revision: D17866247
fbshipit-source-id: 39fb46f4ca3118a106f29f082f2c0ed260df67fd
| hphp/runtime/ext/thrift/compact.cpp | diffblobblamehistory | |
| hphp/test/slow/thrift/range_check.php.expectf | diffblobblamehistory | |
| hphp/test/slow/thrift/range_check_attr.php.expectf | diffblobblamehistory | |
| hphp/test/slow/thrift/range_check_attr_warn.php | [new file with mode: 0644] | blob |
| hphp/test/slow/thrift/range_check_attr_warn.php.expectf | [new file with mode: 0644] | blob |
| hphp/test/slow/thrift/range_check_attr_warn.php.opts | [new file with mode: 0644] | blob |