| commit | b58d4f18b0f7ec1f03bb73bdb277eb8c3c2d84c8 | |
| author | Eric Bluestein <ericblue@fb.com> | |
| Fri, 8 Jun 2018 18:35:54 +0000 (8 11:35 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 11 Jun 2018 16:29:29 +0000 (11 09:29 -0700) | ||
| tree | c8f0736963c165c6efdda444479b773fa25404a4 | treesnapshot (tar.gz zip) |
| parent | 8aba0604372eba7dd9a777db1837e8a8172fed13 | commitdiff |
HHVM Debugger: Add support for warning users when a bp resolves to a memoized function
Summary:
If a breakpoint is set in a function annotated with Memoize, it can lead to user confusion because the function is not actually executed again by HHVM, even if the user invokes it again, when the same parameters are passed to the routine.
This diff adds a console warning that tells the user the function is memoized, and provides a link to the HHVM documentation for more info.
Reviewed By: velocityboy
Differential Revision: D8261897
fbshipit-source-id: 0054a92d6a3645e919ad0e63655c42f4122cb9a2
Summary:
If a breakpoint is set in a function annotated with Memoize, it can lead to user confusion because the function is not actually executed again by HHVM, even if the user invokes it again, when the same parameters are passed to the routine.
This diff adds a console warning that tells the user the function is memoized, and provides a link to the HHVM documentation for more info.
Reviewed By: velocityboy
Differential Revision: D8261897
fbshipit-source-id: 0054a92d6a3645e919ad0e63655c42f4122cb9a2
| hphp/runtime/ext/vsdebug/breakpoint.cpp | diffblobblamehistory | |
| hphp/runtime/ext/vsdebug/breakpoint.h | diffblobblamehistory | |
| hphp/runtime/ext/vsdebug/debugger.cpp | diffblobblamehistory |