| commit | b58792cc0c0a9e1bf33d6e9ae5483eb635f613af | |
| author | Michael Christensen <michristensen@fb.com> | |
| Wed, 5 Aug 2020 00:08:35 +0000 (4 17:08 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 5 Aug 2020 00:38:09 +0000 (4 17:38 -0700) | ||
| tree | bd923fa84e178c82ca3bc6b269d8d6c0b60ee357 | treesnapshot (tar.gz zip) |
| parent | dee7bb6ecf3046da22871c037fc77d4772715d2a | commitdiff |
Use lowest-number error position for line/col position displayed for aggregate positions
Summary: For aggregate positions that are all part of the same file (some displayed with an intermediary ':' between them), the top-level line/col displayed next to the file name needs to reflect the lowest marker number across _all_ position groups for that file, not just the lowest marker for a specific position group.
Reviewed By: Wilfred
Differential Revision: D22851908
fbshipit-source-id: 20c0be376dcff16ecd763a69e20df656360fbcce
Summary: For aggregate positions that are all part of the same file (some displayed with an intermediary ':' between them), the top-level line/col displayed next to the file name needs to reflect the lowest marker number across _all_ position groups for that file, not just the lowest marker for a specific position group.
Reviewed By: Wilfred
Differential Revision: D22851908
fbshipit-source-id: 20c0be376dcff16ecd763a69e20df656360fbcce
| hphp/hack/src/errors/highlighted_error_formatter.ml | diffblobblamehistory | |
| hphp/hack/test/error_formatting_highlighted/big_file.php.exp | diffblobblamehistory |