| commit | b538eff7526d7a52218636735e7b9fabd6e4b128 | |
| author | Jez Ng <jezng@fb.com> | |
| Thu, 14 May 2015 22:41:46 +0000 (14 15:41 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Thu, 14 May 2015 23:00:33 +0000 (14 16:00 -0700) | ||
| tree | 40f1f98878a0008c74cb75fea9a6cea62802de18 | treesnapshot (tar.gz zip) |
| parent | 384c38c0e0971e7cffce18118da75cb484f2c159 | commitdiff |
Have Nast_eval.static_string return a Result type
Summary: Throwing exceptions is error-prone because OCaml can't
exhaustively verify that you've handled all of them. Indeed, I did miss
a spot, and this resulted in lint crashing on some files. This diff
fixes it and makes the code more type-safe.
Reviewed By: @elgenie
Differential Revision: D2070540
Summary: Throwing exceptions is error-prone because OCaml can't
exhaustively verify that you've handled all of them. Indeed, I did miss
a spot, and this resulted in lint crashing on some files. This diff
fixes it and makes the code more type-safe.
Reviewed By: @elgenie
Differential Revision: D2070540
| hphp/hack/src/naming/attributes.ml | diffblobblamehistory | |
| hphp/hack/src/naming/nast_eval.ml | diffblobblamehistory | |
| hphp/hack/src/naming/nast_eval.mli | diffblobblamehistory |