Don't simplify CountArray to CountArrayFast for ProxyArray
commitb48a681e34972acc41b25af93838ae7332ca77c3
authorAlex Malyshev <alexanderm@fb.com>
Mon, 26 Jan 2015 20:34:58 +0000 (26 12:34 -0800)
committerhhvm-bot <hhvm-bot@fb.com>
Mon, 26 Jan 2015 21:00:27 +0000 (26 13:00 -0800)
tree87b7ca6dd81aed38482a0b948aa12247bc2548dd
parent7c3b85353c424d17385fe174f2c0d14ec046f9c8
Don't simplify CountArray to CountArrayFast for ProxyArray

Summary: Noticed by inspection, this has bitten people in open-source using EZC
before. Updated relevant comments and docs to note that it's both GlobalsArray
AND ProxyArray that need to use ArrayData::vsize().

Reviewed By: @paulbiss

Differential Revision: D1800979
hphp/doc/ir.specification
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/test/simplifier.cpp
hphp/runtime/vm/jit/simplify.cpp