record start+end times of hh invocations
commitb451812551ad4e2be7ea001865d02e0497430afd
authorLucian Wischik <ljw@fb.com>
Thu, 21 May 2020 10:12:47 +0000 (21 03:12 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 21 May 2020 10:19:45 +0000 (21 03:19 -0700)
treeddad9ac34b3991c3c92a64f51783393acbc7bcf1
parent59c4d453197a7f19935994e35f7be7a8485dcf38
record start+end times of hh invocations

Summary:
I'm investigating a rage report. I'm puzzled by the timings shown in the server logs. I'd like to get a timestamp for when `hh rage` invokes two subsidiary invocations of hh (one for server-state, one to get errors). That's what this diff provides.

Other system-wide changes rolled in:
1. I augmented `Process_success.t` and `Process_failure.t` to keep a record of start+end times.
2. I consolidated all "float->timestring" conversions into a single central Utils.timestring function. (previously it existed in Hh_logger and typing_service_state_utils)

Reviewed By: arxanas

Differential Revision: D21672405

fbshipit-source-id: f1400aa444c735ba930e182702585cffcaa7917a
hphp/hack/src/client/clientRage.ml
hphp/hack/src/utils/core/hh_logger.ml
hphp/hack/src/utils/core/hh_logger.mli
hphp/hack/src/utils/core/utils.ml
hphp/hack/src/utils/core/utils.mli
hphp/hack/src/utils/lwt_utils.ml
hphp/hack/src/utils/lwt_utils.mli
hphp/hack/test/utils/lwt_utils_test.ml