| commit | b419c9babf0d03dc7aabbf986b4ef9d7ced68bef | |
| author | Vassil Mladenov <vmladenov@fb.com> | |
| Fri, 29 Jan 2021 00:57:20 +0000 (28 16:57 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 29 Jan 2021 01:01:46 +0000 (28 17:01 -0800) | ||
| tree | 900ba287383b49dd74913fae29f728f0d5a5ff0e | treesnapshot (tar.gz zip) |
| parent | ac99e45f61c312ef072a3cf886ef246195709669 | commitdiff |
Better error messages for non-object access
Summary: The non_object_member error would previously refer to a type constant as a property because of the binary ~is_method argument. There's already a polymorphic variant `class_member_kind` used for static members that is used elsewhere in Errors, so I extended it to cover methods and properties and used that.
Reviewed By: losvald
Differential Revision: D26120916
fbshipit-source-id: 31b8d254f38b21456ab1fdef494c549357388a53
Summary: The non_object_member error would previously refer to a type constant as a property because of the binary ~is_method argument. There's already a polymorphic variant `class_member_kind` used for static members that is used elsewhere in Errors, so I extended it to cover methods and properties and used that.
Reviewed By: losvald
Differential Revision: D26120916
fbshipit-source-id: 31b8d254f38b21456ab1fdef494c549357388a53