| commit | b338524437df5cba754074d49ad1150287d3fc19 | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Thu, 28 Jan 2021 03:12:09 +0000 (27 19:12 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 28 Jan 2021 03:14:22 +0000 (27 19:14 -0800) | ||
| tree | 5494ca5afced70f42b00d8342c33778a4a01fc93 | treesnapshot (tar.gz zip) |
| parent | 4636ff6b80f696ed510d6fc11584af201abcbd67 | commitdiff |
Delete getInt / getStr helpers
Summary: The reason I didn't use CallSpec::method for these getters before was because ArrayData::get has an optional bool parameter. Let's split out that overload so that we can target the method. colavitam has some inlining changes that dramatically improve these methods.
Reviewed By: colavitam
Differential Revision: D26076684
fbshipit-source-id: 821b523724e3a96f294ce6cd671523f634a4344b
Summary: The reason I didn't use CallSpec::method for these getters before was because ArrayData::get has an optional bool parameter. Let's split out that overload so that we can target the method. colavitam has some inlining changes that dramatically improve these methods.
Reviewed By: colavitam
Differential Revision: D26076684
fbshipit-source-id: 821b523724e3a96f294ce6cd671523f634a4344b
| hphp/runtime/base/array-data-defs.h | diffblobblamehistory | |
| hphp/runtime/base/array-data.h | diffblobblamehistory | |
| hphp/runtime/vm/jit/irlower-bespoke.cpp | diffblobblamehistory |