| commit | b29225e843ff83a0a0d505edeebfc6de9dd8aaa6 | |
| author | bsimmers <bsimmers@fb.com> | |
| Fri, 9 May 2014 19:23:50 +0000 (9 12:23 -0700) | ||
| committer | JoelMarcey <joelm@fb.com> | |
| Thu, 15 May 2014 01:43:15 +0000 (14 18:43 -0700) | ||
| tree | 283ef133390a4d119108a815862fe47eb4b003c5 | treesnapshot (tar.gz zip) |
| parent | 98b54bd1dd2cf78ffbaa470d746236866257952f | commitdiff |
Fix refcount-opts for $this in static functions
Summary: The changes to refcount-opts.cpp are sufficient to fix the crash but I
decided to do a little related cleanup. I properly implemented the null $this
fatal for This and CheckThis and changed preOptimizeLdThis to generate cleaner
code in cases like this. It won't help perf but the resulting code is much less
embarrassing.
Reviewed By: @alexmalyshev
Differential Revision: D1321977
Summary: The changes to refcount-opts.cpp are sufficient to fix the crash but I
decided to do a little related cleanup. I properly implemented the null $this
fatal for This and CheckThis and changed preOptimizeLdThis to generate cleaner
code in cases like this. It won't help perf but the resulting code is much less
embarrassing.
Reviewed By: @alexmalyshev
Differential Revision: D1321977